Skip to content

[skip changelog] Revert "Add skip changelog prefix to Dependabot workflow update commits (#1381)" #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[skip changelog] Revert "Add skip changelog prefix to Dependabot workflow update commits (#1381)" #1389

merged 1 commit into from
Aug 12, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 11, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Infrastructure fix

  • What is the current behavior?

The Dependabot configuration specifies that the message title of the commits generated by Dependabot will be prefixed with "[skip changelog]" in order to cause them to be automatically excluded from the generated changelog (#1381).

It turns out there is an undocumented maximum length of 15 characters for the Dependabot commit prefix:

https://github.com/arduino/arduino-cli/network/updates

Dependabot encountered the following error when parsing your .github/dependabot.yml:

The property '#/updates/0/commit-message/prefix' was not of a maximum string length of 15
Please update the config file to conform with Dependabot's specification.

Unfortunately, even though it is possible to reduce the prefix length by 1 with the removal of the trailing space, we
still end up with 16 characters.

  • What is the new behavior?

The commit message prefix configuration is removed, making the file compliant once more. Dependabot's commits will follow the default message style.

No break

…flow update commits (#1381)"

This reverts commit 4fbf7b7.

It turns out there is an undocumented maximum length of 15 characters for this prefix:

https://github.com/arduino/arduino-cli/network/updates

```
Dependabot encountered the following error when parsing your .github/dependabot.yml:

The property '#/updates/0/commit-message/prefix' was not of a maximum string length of 15
Please update the config file to conform with Dependabot's specification.
```
Unfortunately, even though it is possible to reduce the prefix length by 1 with the removal of the trailing space, we
still end up with 16 characters.
@per1234 per1234 added type: bug topic: infrastructure Related to project infrastructure labels Aug 11, 2021
@per1234 per1234 merged commit d052cf6 into arduino:master Aug 12, 2021
@per1234 per1234 deleted the revert-dependabot-prefix branch August 12, 2021 07:51
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants